Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buffering when using reserved connections #8102

Merged
merged 9 commits into from
May 18, 2021
Merged

Fix buffering when using reserved connections #8102

merged 9 commits into from
May 18, 2021

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented May 11, 2021 •
edited by systay

Description

Reserved connections were not working well during reparenting. This PR makes it work.

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@harshit-gangal @systay
added reserved connection buffer test
7185eb1 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal @systay
update timeout values
3d0414c 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay
make sure to block state transitions when doing ReserveBegin
ad4d63f 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@harshit-gangal
fix the error message
7bd1c6a 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
reset the shard session for reserved connection if the error is cause…
5e1619a 
…d by failover

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal
buffer test more assert
f5c2920 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal changed the title added reserved connection buffer test Fix tx engine to wait for begin request to complete on reserved connection before any state change May 12, 2021
@harshit-gangal
on beginExecute failure check for retryRequest than not trying if tra…
ffcd06f 
…nsaction id is non-zero

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal requested review from systay, deepthi and sougou and removed request for deepthi May 13, 2021 15:09
@harshit-gangal
buffer test changes
297f55c 
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@systay
Trigger rebuild
033b918 
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay marked this pull request as ready for review May 17, 2021 06:57
@systay systay requested a review from shlomi-noach as a code owner May 17, 2021 06:57
@systay systay changed the title Fix tx engine to wait for begin request to complete on reserved connection before any state change Fix buffering when using reserved connections May 17, 2021
@systay systay merged commit 39c1859 into vitessio:master May 18, 2021
@systay systay deleted the rc-qbuf branch May 18, 2021 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@systay systay systay approved these changes

@sougou sougou Awaiting requested review from sougou

@deepthi deepthi Awaiting requested review from deepthi

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

Assignees
No one assigned
Labels
Component: Query Serving Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harshit-gangal @systay