[vtadmin-web] Add Keyspace detail view #8111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
ajm188
approved these changes
May 14, 2021
| // and you match a shard, and also _some_ tablets in the shard -- do you show all | ||
| // of the tablets (since the shard matches), or (more likely) just the filtered ones? | ||
| // | ||
| // Instead of doing a complicated-and-hacky solution, this approach is a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com
Description
This PR adds the foundation for the Keyspace detail view, starting with a listing of shards + tablets.
A caveat: grouping table rows by shard complicates the filtering, since
filterNounswasn't written to handle nested properties. For now, "kinda gross but exhaustively commented hacks that work 90% of the time in this one place" seemed a better trade-off than "don't add filtering until we can handle this in a nicely generalized way". (Especially since using a library like https://fusejs.io is a better long-term filtering solution anyway ... who wants to maintain regexes? (Not me!)). I ticketed https://github.com/vitessio/vitess/projects/12#card-60968004 to investigate a more robust solution, when we get time.Here's what it looks like:
And a weird, semi-error state just for fun:
Related Issue(s)
N/A
Checklist
Deployment Notes
N/A