Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin-api] Replace magic numbers with net/http constants #8127

Merged
merged 1 commit into from
May 14, 2021
Merged

[vtadmin-api] Replace magic numbers with net/http constants #8127

merged 1 commit into from
May 14, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented May 14, 2021

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

Related Issue(s)

Checklist

  • Tests were added or are not required -- N/A
  • Documentation was added or is not required -- N/A

Deployment Notes

@ajm188
[vtadmin-api] Replace magic numbers with net/http constants
b5b7a6c 
Signed-off-by: Andrew Mason <amason@slack-corp.com>
@ajm188 ajm188 requested a review from doeg May 14, 2021 15:59
@ajm188 ajm188 added this to In progress in VTAdmin via automation May 14, 2021
@ajm188 ajm188 merged commit 68f28c0 into vitessio:master May 14, 2021
VTAdmin automation moved this from In progress to Done May 14, 2021
@ajm188 ajm188 deleted the am_vtadmin_status_codes branch May 14, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doeg doeg doeg approved these changes

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface Type: Internal Cleanup
Projects
VTAdmin
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[vtadmin] Swap magic numbers in HTTPStatus implementations for the constants in package net/http
2 participants
@ajm188 @doeg