VReplication Copy Phase: Increase default replica lag tolerance. Also make it and copy timeout modifiable via flags #8130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and replica log tolerance via flags Signed-off-by: Rohit Nayak <rohit@planetscale.com>
askdba
added
Component: VReplication
Type: Enhancement
harshit-gangal
approved these changes
May 17, 2021
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
VReplication decides to switch from catchup to bulk copy when the replica lag is under a threshold. This was 10 seconds, which could cause a problem under certain circumstances (see #8104).
The default has been increased to a minute and it also been made into a flag
-vreplication_replica_lag_tolerance <seconds>in case fine tuning is needed.The time for which the bulk insert phase runs is currently 1 hour. That can now be changed via a flag
-vreplication_copy_phase_duration <seconds>. You will not need to modify either of these normally.Signed-off-by: Rohit Nayak rohit@planetscale.com
Related Issue(s)
#8104
Checklist