Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vtadmin-api] Rename flag 'http-tablet-fqdn-tmpl' to 'http-tablet-url-tmpl' + update vtadmin flags for local example #8164

Merged
merged 2 commits into from
May 20, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 20, 2021

Description

  • Renames flag 'http-tablet-fqdn-tmpl' to 'http-tablet-url-tmpl' (since it requires the protocol)
  • Updates the local example to include both http-tablet-url-tmpl and tablet-fqdn-tmpl flags
curl "http://localhost:14200/api/tablets" | jq .
{
  "result": {
    "tablets": [
      {
        "cluster": {
          "id": "local",
          "name": "local"
        },
        "tablet": {
          "alias": {
            "cell": "zone1",
            "uid": 100
          },
          "hostname": "localhost",
          "keyspace": "commerce",
          "shard": "0",
          "type": 1,
          "master_term_start_time": {
            "seconds": 1621541573
          }
        },
        "state": 1,
        "FQDN": "localhost:15100"
      },
      {
        "cluster": {
          "id": "local",
          "name": "local"
        },
        "tablet": {
          "alias": {
            "cell": "zone1",
            "uid": 101
          },
          "hostname": "localhost",
          "keyspace": "commerce",
          "shard": "0",
          "type": 2
        },
        "state": 1,
        "FQDN": "localhost:15101"
      },
      {
        "cluster": {
          "id": "local",
          "name": "local"
        },
        "tablet": {
          "alias": {
            "cell": "zone1",
            "uid": 102
          },
          "hostname": "localhost",
          "keyspace": "commerce",
          "shard": "0",
          "type": 3
        },
        "state": 1,
        "FQDN": "localhost:15102"
      }
    ]
  },
  "ok": true
}
curl "http://localhost:14200/api/experimental/tablet/zone1-102/debug/vars"

(Redacted most of the response, since it's really long.)

{"result":{"AppConnPoolActive":0,"AppConnPoolAvailable":40,"AppConnPoolCapacity":40,"AppConnPoolExhausted":0,"AppConnPoolIdleClosed":0,"AppConnPoolIdleTimeout":60000000000,"AppConnPoolInUse":0,"AppConnPoolMaxCap":40,"AppConnPoolWaitCount":0,"AppConnPoolWaitTime":0,"BackupIsRunning":{},

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

doeg added 2 commits May 20, 2021 16:24
…-tmpl'

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
…dn-tmpl' flags

Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg requested review from rafael and ajm188 May 20, 2021 20:32
@doeg doeg requested a review from rohit-nayak-ps as a code owner May 20, 2021 20:32
@doeg doeg added Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature) labels May 20, 2021
@doeg doeg added this to In progress in VTAdmin via automation May 20, 2021
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thank you for taking this one!

@ajm188 ajm188 merged commit 1c043df into vitessio:master May 20, 2021
VTAdmin automation moved this from In progress to Done May 20, 2021
@ajm188 ajm188 deleted the sarabee-vtadmin-fqdns-and-urls branch May 20, 2021 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants