VReplicationExec: don't create new stats objects on a select #8166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…update and not for select since NewStats() creates a new goroutine which is never cleaned up at the moment Signed-off-by: Rohit Nayak <rohit@planetscale.com>
deepthi
approved these changes
May 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With a recent change we ended up creating a new stats object for every call to VReplicationExec, as part of creating a new VDBClient. However each stats object also creates a goroutine which never gets cleaned up. In PSDB there is a monitoring call to get a list of all workflows every few seconds. This creates resource starvation due to the number of orphan goroutines that keep running.
This PR fixes this immediate problem by only creating the VDBClient on insert/update/delete and not select.
In the long term we need to cleanup the goroutines for stats objects that are no longer in scope.
Related Issues
#7818