Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary key name #8188

Merged
merged 3 commits into from
May 26, 2021
Merged

Primary key name #8188

merged 3 commits into from
May 26, 2021

Conversation

GuptaManan100
Copy link
Member

Description

MySQL allows syntax like

alter table t2 add primary key `zzz` (id);
Query OK, 0 rows affected (0.06 sec)

This PR adds support for adding an optional name to the primary key constraint, which is ignored.

Related Issue(s)

Fixes #8149

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

GuptaManan100 and others added 2 commits May 25, 2021 18:07
@GuptaManan100
added a failing test
70ce3f5 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@GuptaManan100 @frouioui
added optional naming to primary key constraint
94d936f 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Co-authored-by: frouioui <florent.poinsard@outlook.fr>
@GuptaManan100 GuptaManan100 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving labels May 25, 2021
@GuptaManan100 GuptaManan100 self-assigned this May 25, 2021
@GuptaManan100
fixed test
be118c8 
Signed-off-by: GuptaManan100 <manan@planetscale.com>
@shlomi-noach shlomi-noach merged commit c32a770 into vitessio:master May 26, 2021
@shlomi-noach shlomi-noach mentioned this pull request May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shlomi-noach shlomi-noach shlomi-noach approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal

@systay systay Awaiting requested review from systay

Assignees

@GuptaManan100 GuptaManan100

Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parser: support named PRIMARY KEY even though the syntax is not technically valid
2 participants
@GuptaManan100 @shlomi-noach