[workflow] Cleanup wrangler wrappers, migrate checkIfJournalExistsOnTablet to package workflow
#8193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <amason@slack-corp.com>
…ge workflow I also removed the unnecessary `if !exists` check, since not taking that path was impossible. Signed-off-by: Andrew Mason <amason@slack-corp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What it says in the title. I think long-term that the (newly-named)
CheckReshardingJournalExistsOnTabletshould stop being exported, but we need to access it from package wrangler for now, so I left a TODO comment.Also, the previous implementation had an unnecessary check on
if !existswhich would always be true, so I removed the check.[Edit] Oh, also, this is almost certainly going to run into merge conflicts with #8190 so 🤷 I'll just rebase whichever one loses
Related Issue(s)
#7931
Checklist
Deployment Notes