Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vtadmin-web] Add tabs to Workflow view #8203

Merged
merged 1 commit into from
May 28, 2021
Merged

[vtadmin-web] Add tabs to Workflow view #8203

merged 1 commit into from
May 28, 2021

Conversation

doeg
Copy link
Contributor

@doeg doeg commented May 28, 2021

Signed-off-by: Sara Bee 855595+doeg@users.noreply.github.com

Description

  • Adds two tabs ("Streams", "JSON") to the Workflow view
  • Extracts WorkflowStreams into its own component, with no actual changes

This diff looks a lot worse than it is!

Screen Shot 2021-05-28 at 1 21 03 PM

Screen Shot 2021-05-28 at 1 21 05 PM

Related Issue(s)

N/A

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

N/A

@doeg
[vtadmin-web] Add tabs to Workflow view
686d61d 
Signed-off-by: Sara Bee <855595+doeg@users.noreply.github.com>
@doeg doeg added this to In progress in VTAdmin via automation May 28, 2021
@doeg doeg added Component: VTAdmin VTadmin interface Type: Internal Cleanup Type: Enhancement Logical improvement (somewhere between a bug and feature) and removed Type: Internal Cleanup labels May 28, 2021
ajm188
ajm188 approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajm188 ajm188 merged commit a1e0047 into vitessio:master May 28, 2021
VTAdmin automation moved this from In progress to Done May 28, 2021
@ajm188 ajm188 deleted the sarabee-workflow-tabs branch May 28, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajm188 ajm188 ajm188 approved these changes

@rafael rafael Awaiting requested review from rafael

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps

Assignees
No one assigned
Labels
Component: VTAdmin VTadmin interface Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
VTAdmin
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doeg @ajm188