Adds an environment variable to set the MySQL max connections limit in vttestserver docker image #8210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GuptaManan100 <manan@planetscale.com>
GuptaManan100
added
Type: Enhancement
GuptaManan100
requested review from
mcronce,
harshit-gangal and
systay
and removed request for
dkhenry and
derekperkins
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
8 tasks
|
The new test added is failing. @GuptaManan100 you need to look into it. |
Signed-off-by: GuptaManan100 <manan@planetscale.com>
|
@harshit-gangal cluster 12 seems to already have sufficient tests running on it, adding docker tests to it makes it fail with 11-minute timeout. I have moved the tests to run on cluster 26 instead since they had the least amount of tests currently. |
Signed-off-by: GuptaManan100 <manan@planetscale.com>
GuptaManan100
force-pushed
the
vttestserver-mysql-connections
branch
from
30a4ac3
to
f9f6f75
Compare
|
reverted the tests for now. Will add them as a separate PR is needed |
harshit-gangal
approved these changes
Jun 1, 2021
|
Tests are added in #8253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an environment variable to set the MySQL max connections limit in vttestserver docker image. This will allow the users to set the MySQL
max_connectionseven in the docker image of vttestserver.Checklist