Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL Vreplication test suite: adding tests #8213

Merged
merged 13 commits into from
Jun 1, 2021
Merged

Online DDL Vreplication test suite: adding tests #8213

merged 13 commits into from
Jun 1, 2021

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented May 31, 2021 •
edited

Description

Follow up to #8181. This PR adds a few dozen tests that "just pass" with VReplication based online DDL. Making those tests pass required some updates to the testing logic, but none to the Vitess codebase itself (ie nothing under go/vt/)

There's still many outstanding tests under untestdata directory. Importing those is likely to require code changes in VReplication or in Online DDL code.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@shlomi-noach
online DDL vreplication suite: adding all known PASSing tests
82ce49e 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
fixed ordering of expected/got params
3567576 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
fixed 'before_columns' and 'after_columns'
ef32739 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
ensure to terminate migratio upon test end, whatever the state of the…
84f033f 
… migration is

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
ensure table is created
bc5dcdf 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
more PASSing tests
4380f0c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
support vtgate expected failures
2232a7c 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
fail-syntax-error test
1fc5ea7 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
we can't compare output via formal QueryResult object, because some o…
a32b7b7 
…f our tests modify column type (eg DATETIME->TIMESTAMP) and that creates false failures in require.Equal comparison. Instead, we use the gh-ost script approach and export the data textually via mysql client, and compare textual output

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
run mysql client in silent mode, we don't want to export column names…
a0a0e7d 
… because some of our tests rename columns

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
removed irrelevant tests
bd7d17e 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
a couple more passing tests
7426d62 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Merge branch 'master' into online-ddl-vreplication-test-suite-add-part-1
a88b841 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

These are the tests enabled in this PR:

--- PASS: TestSchemaChange (445.50s)
    --- PASS: TestSchemaChange/bigint-change-nullable (11.11s)
    --- PASS: TestSchemaChange/bit-add (9.05s)
    --- PASS: TestSchemaChange/bit-dml (10.05s)
    --- PASS: TestSchemaChange/datetime (10.05s)
    --- PASS: TestSchemaChange/datetime-1970 (10.05s)
    --- PASS: TestSchemaChange/datetime-submillis (10.05s)
    --- PASS: TestSchemaChange/datetime-submillis-zeroleading (10.06s)
    --- PASS: TestSchemaChange/datetime-to-timestamp (10.06s)
    --- PASS: TestSchemaChange/decimal (10.06s)
    --- PASS: TestSchemaChange/discard-fk (10.06s)
    --- PASS: TestSchemaChange/enum (10.05s)
    --- PASS: TestSchemaChange/fail-nonexistent-column (5.03s)
    --- PASS: TestSchemaChange/fail-syntax-error (0.01s)
    --- PASS: TestSchemaChange/gbk-charset (10.05s)
    --- PASS: TestSchemaChange/generated-columns-add57 (10.05s)
    --- PASS: TestSchemaChange/generated-columns-rename57 (10.06s)
    --- PASS: TestSchemaChange/generated-columns57 (10.05s)
    --- PASS: TestSchemaChange/geometry57 (10.05s)
    --- PASS: TestSchemaChange/keyword-column (10.05s)
    --- PASS: TestSchemaChange/latin1 (10.05s)
    --- PASS: TestSchemaChange/latin1text (9.05s)
    --- PASS: TestSchemaChange/mixed-charset (10.05s)
    --- PASS: TestSchemaChange/modify-change-case (10.06s)
    --- PASS: TestSchemaChange/rename (10.06s)
    --- PASS: TestSchemaChange/rename-inserts-only (10.05s)
    --- PASS: TestSchemaChange/rename-none-column (10.05s)
    --- PASS: TestSchemaChange/rename-none-comment (10.05s)
    --- PASS: TestSchemaChange/rename-reorder-column (10.05s)
    --- PASS: TestSchemaChange/rename-reorder-columns (10.05s)
    --- PASS: TestSchemaChange/reorder-columns (10.05s)
    --- PASS: TestSchemaChange/spatial57 (10.05s)
    --- PASS: TestSchemaChange/swap-uk (10.05s)
    --- PASS: TestSchemaChange/timestamp (10.05s)
    --- PASS: TestSchemaChange/timestamp-datetime (10.06s)
    --- PASS: TestSchemaChange/timestamp-to-datetime (10.06s)
    --- PASS: TestSchemaChange/trivial (10.05s)
    --- PASS: TestSchemaChange/tz (10.05s)
    --- PASS: TestSchemaChange/tz-datetime (10.05s)
    --- PASS: TestSchemaChange/tz-datetime-ts (9.06s)
    --- PASS: TestSchemaChange/unsigned (10.06s)
    --- PASS: TestSchemaChange/unsigned-modify (10.05s)
    --- PASS: TestSchemaChange/unsigned-rename (10.06s)
    --- PASS: TestSchemaChange/unsigned-reorder (10.05s)
    --- PASS: TestSchemaChange/utf8 (10.05s)
    --- PASS: TestSchemaChange/utf8mb4 (10.05s)
    --- PASS: TestSchemaChange/varbinary (10.06s)
PASS

rohit-nayak-ps
rohit-nayak-ps approved these changes May 31, 2021
View reviewed changes
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shlomi-noach shlomi-noach merged commit 6208915 into vitessio:master Jun 1, 2021
@shlomi-noach shlomi-noach deleted the online-ddl-vreplication-test-suite-add-part-1 branch June 1, 2021 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps approved these changes

Assignees
No one assigned
Labels
Component: Build/CI Component: Query Serving Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shlomi-noach @rohit-nayak-ps