Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor vtorc endtoend tests #8215

Merged
merged 5 commits into from
Jun 1, 2021
Merged

Refactor vtorc endtoend tests #8215

merged 5 commits into from
Jun 1, 2021

Conversation

shlomi-noach
Copy link
Contributor

@shlomi-noach shlomi-noach commented May 31, 2021 •
edited

Description

This is a refactor that moves things around, but does not change any logic.

  • We have settled on the term vtorc, as opposed to orchestrator and decider. Renamed tests to vtorc to reflect that.
  • vtorc now has its own endtoend shard. The shard is named vtorc.

Related issues

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

@shlomi-noach
extract endtoend/vtorc to its own test shard
d5aecbe 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
package name is vtorc
0a58a54 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach shlomi-noach changed the title Refactor vtord endtoend tests Refactor vtorc endtoend tests May 31, 2021
@shlomi-noach
Wait for read_only condition instead of sleep
06e0203 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

I lied just a wee bit. Made a minor change to the test: iterative wait for condition instead of sleeping 15 seconds.

@shlomi-noach
Copy link
Contributor Author

hmmm great. My changes in 06e0203 broke the test. Looking into.

@shlomi-noach
wait for value: int type
71f46a4 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
check on replica
411de37 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
GuptaManan100
GuptaManan100 approved these changes Jun 1, 2021
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🐎

@shlomi-noach shlomi-noach merged commit 879d6bb into vitessio:master Jun 1, 2021
@shlomi-noach shlomi-noach deleted the vtorc-endtoend-test branch June 1, 2021 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@deepthi deepthi Awaiting requested review from deepthi

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shlomi-noach @GuptaManan100