-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vtctldserver] Migrate CellInfo
, CellAlias
rw RPCs
#8219
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Jun 1, 2021
} | ||
// AddCellsAlias makes an AddCellsAlias gRPC call to a vtctld. | ||
AddCellsAlias = &cobra.Command{ | ||
Use: "AddCellsAlias --cells <cell1,cell2,...> [--cells <cell3> ...] <alias>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious: why is the --cells
flag defined twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am still unsure how to best convey this in usage strings, but pflag.StringSlice
lets you do:
-x "a,b" # result: [a, b]
-x "a" -x "b" # result: [a, b]
-x "a,b" -x "c" # result: [a, b, c]
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
[vtctldserver] Migrate `CellInfo`, `CellAlias` rw RPCs Signed-off-by: Andrew Mason <amason@slack-corp.com>
8 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This migrates the read-write cell and cell alias vtctl commands to the grpc vtctldserver, namely:
AddCellInfo
AddCellsAlias
DeleteCellInfo
DeleteCellsAlias
UpdateCellInfo
UpdateCellsAlias
Note, there is an underlying issue in the
(*topo.Server).DeleteCellInfo
method, which I'm filing a bug for, and will link back here when I do.Example usage
Related Issue(s)
Checklist
Deployment Notes