Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Online DDL/VReplication: more passing tests (no UK/PK) #8225

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Online DDL/VReplication: more passing tests (no UK/PK) #8225

merged 1 commit into from
Jun 2, 2021

Conversation

shlomi-noach
Copy link
Contributor

Description

More passing tests: no shared PRIMARY KEY or UNIQUE KEY. Only had to change wording for tests to pass.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
Online DDL/VReplication: more passing tests (no UK/PK)
d3f769d 
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

The tests introduced in this PR:

Jun 01 10:48:10     --- PASS: TestSchemaChange/fail-drop-pk (2.06s)
Jun 01 10:48:10     --- PASS: TestSchemaChange/fail-float-unique-key (4.07s)
Jun 01 10:48:10     --- PASS: TestSchemaChange/fail-no-unique-key (4.07s)

GuptaManan100
GuptaManan100 approved these changes Jun 2, 2021
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐺

@shlomi-noach shlomi-noach merged commit 3b86569 into vitessio:main Jun 2, 2021
@shlomi-noach shlomi-noach deleted the online-ddl-vrepl-suite-no-pk-uk branch June 2, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

Assignees
No one assigned
Labels
Component: Build/CI Component: Query Serving Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shlomi-noach @GuptaManan100