Online DDL/VReplication: fail on existence of FOREIGN KEY #8228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…arget table Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
…t broke is irrelevant to vreplication Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Importing
fail-fktest from thegh-ostsuite:This PR ensures the migrated table does not participate in a foreign key relationship.
Today, we reject any
ALTER/CREATEstatements that include anyFOREIGN KEYclause. But what if the user created a table with foreign keys directly on MySQL?With this PR, a
onlinestrategy migration validates that no FKs exist on the table, child side or parent side.It's noteworth ythat
gh-ostruns this same test internally; so I've only added the logic toonline/vreplication strategy.Related Issue(s)
Checklist