Speedup new vttestserver tests #8229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd TestDDLModes() into a single TestForiegnKeysAndDDLModes() to reduce the number of cluster spinup/teardown cycles we need to do Signed-off-by: Mike Cronce <mc@planetscale.com>
mcronce
force-pushed
the
speedup-new-vttestserver-tests
branch
from
32d5835
to
771128d
Compare
added 2 commits
June 1, 2021 14:51
…): Why did I have semicolons in these SET queries? Signed-off-by: Mike Cronce <mc@planetscale.com>
…): Cleanup meaningless assignments Signed-off-by: Mike Cronce <mc@planetscale.com>
dkhenry
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests added in #8177 substantially increases the time required to run that test suite (on the order of 20-40 seconds) because of all the additional spinup/teardown cycles; this combines the new tests into a single spinup/teardown cycle. It reduces readability a bit (IMO) but given the amount of time it saves, I think it's a worthwhile trade.
Related Issue(s)
#8177
Checklist
Deployment Notes
N/A