/healthz should not report ok when vttablet is not connected to mysql #8238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-restore_from_backup), as we do in the Vitess Operator, /healthz reports "ok" until MySQLd is up, which is bad. Explicitly check for the not connected state, and add tests for the /healthz handler. Signed-off-by: Jacques Grove <aquarapid@gmail.com>
aquarapid
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
harshit-gangal
removed request for
rafael,
systay,
shlomi-noach and
harshit-gangal
harshit-gangal
approved these changes
Jun 2, 2021
deepthi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When MySQLd is starting under vttablet control (e.g. when using
-restore_from_backup),as we do in the Vitess Operator,
/healthzreports "ok" untilmysqldis up, which is bad. Explicitly check for thenot connected state, and add tests for the /healthz handler.
Fixes #8237
Signed-off-by: Jacques Grove aquarapid@gmail.com
One issue here is that there may be existing operational flows that depend on this broken behavior.