Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Tracking: Optimize and Bug Fix #8243

Merged
merged 8 commits into from
Jun 8, 2021
Merged

Conversation

harshit-gangal
Copy link
Member

@harshit-gangal harshit-gangal commented Jun 2, 2021

Description

Load full schema only on start of VTGate and when the tablet goes from non-serving to serving on primary tablet.
Fixed some corner cases.

Related Issue(s)

#7994
#7995

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Jun 2, 2021
…hema

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…or the keyspace when it is set and set to false when successfully loaded

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
… the full schema next time. if the updates tables fetches error, mark the tracker to reload the full schema next time.

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ered with tracker

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
@harshit-gangal harshit-gangal changed the title Schema Tracking Optimize VTGate Schema Tracking Jun 7, 2021
@harshit-gangal harshit-gangal marked this pull request as ready for review June 7, 2021 18:49
@systay systay requested a review from frouioui June 7, 2021 19:31
go/vt/vtgate/schema/tracker.go Outdated Show resolved Hide resolved
go/vt/vtgate/schema/uptate_controller.go Show resolved Hide resolved
go/vt/vtgate/schema/uptate_controller.go Outdated Show resolved Hide resolved
@harshit-gangal harshit-gangal changed the title Optimize VTGate Schema Tracking Schema Tracking: Optimize and Bug Fix Jun 8, 2021
…non-primary upfront

Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome to me!

@systay systay merged commit 18dbd43 into vitessio:main Jun 8, 2021
@systay systay deleted the st-2 branch June 8, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants