VStream API: add heartbeat for idle streams #8244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohit-nayak-ps
force-pushed
the
rn-vstream-heartbeat
branch
from
201ee0b
to
aa14f1c
Compare
rohit-nayak-ps
added
Component: VReplication
Type: Enhancement
…ds to be an option Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
rohit-nayak-ps
force-pushed
the
rn-vstream-heartbeat
branch
from
3e17362
to
f08ea05
Compare
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
vmg
reviewed
Jun 21, 2021
vmg
reviewed
Jun 21, 2021
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently if all source shards have 0 QPS the VStream API will not send any events. So if a client doesn't receive events it is not clear if the connection is broken or idle. This PR adds an optional heartbeat which is sent if there are no events within a specified time period.
Earlier streams used to just invoke the passed callback. Now they send events to a shared channel. We initiate an idle timer here to send heartbeats if no events are received in
flags.HeartbeatInterval.Misc
Checklist