Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Materialize: Add additional comparison operators in Materialize and fix bug where they not applied for sharded keyspaces #8247

Merged
merged 5 commits into from
Jun 9, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

This PR fixes a bug where comparison filters were being ignored in Materialize workflows if the source keyspace was sharded.

In addition, it adds support for additional operators (>, >=, <, <=, <>) . The filter expression can chain multiple comparison operations using and only.

Examples:

select * from t1 where id = 1
select * from t1 where id <> 1
select * from t1 where val > 'abc'
select * from t1 where id >= 1
select * from t1 where id < 2 and val <= 'xyz'

Signed-off-by: Rohit Nayak rohit@planetscale.com

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

…g where comparison operators were not applied for sharded keyspaces

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps added Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Jun 2, 2021
@rohit-nayak-ps
Copy link
Contributor Author

#8069 has been moved over here due to issues with rebasing against main

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps requested review from deepthi, shlomi-noach and a team June 7, 2021 20:03
@rohit-nayak-ps rohit-nayak-ps marked this pull request as ready for review June 7, 2021 20:04
@deepthi
Copy link
Member

deepthi commented Jun 7, 2021

@shlomi-noach @sougou can you re-review? It seems like all feedback from #8069 has been addressed.

@rohit-nayak-ps rohit-nayak-ps merged commit a4582b7 into vitessio:main Jun 9, 2021
@rohit-nayak-ps rohit-nayak-ps deleted the rn-mat-operator-bug2 branch June 9, 2021 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants