naming: master to primary #8251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…precate old funcs Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
requested review from
harshit-gangal,
rohit-nayak-ps,
shlomi-noach and
systay
as code owners
deepthi
requested review from
a team
and removed request for
systay,
shlomi-noach,
harshit-gangal and
rohit-nayak-ps
deepthi
force-pushed
the
ds-master-to-primary1
branch
from
4275603
to
b1a7627
Compare
Signed-off-by: deepthi <deepthi@planetscale.com>
deepthi
force-pushed
the
ds-master-to-primary1
branch
from
b1a7627
to
82f0ffe
Compare
ajm188
approved these changes
Jun 5, 2021
systay
approved these changes
Jun 7, 2021
systay
reviewed
Jun 7, 2021
go/mysql/flavor.go
Outdated
| // MasterPosition returns the current master replication position. | ||
| func (c *Conn) MasterPosition() (Position, error) { | ||
| gtidSet, err := c.flavor.masterGTIDSet(c) | ||
| // PrimaryPosition returns the current master replication position. |
There was a problem hiding this comment.
nit: change the comment as well?
Signed-off-by: deepthi <deepthi@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename funcs on mysqld, add new funcs on tabletmanager and deprecate old funcs.
These changes are purely internal right now, the new RPCs have not yet been exposed. That will be a separate PR.
Related Issue(s)
#7114
Checklist
Deployment Notes