Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds debug endpoints to vtadmin-api, namely the
/debug/pprof/
friends, and also a/debug/env
to show environment variables available to the vtadmin-api process.net/http/pprof was being stubborn about how to get it to play nicely with gorilla/mux, but I managed to get it working, unfortunately at the cost of making the route registration a bit more confusing.
We also add some config options to opt users out of debug endpoints entirely, as well as to control the behavior of the
/debug/env
endpoint to sanitize, or omit entirely, any environment variables that may be sensitive.Examples!
No changes to flags:
Adding sanitization:
Adding omission:
Disabling entirely:
I also poked around in the pprof endpoints and took some profiles.
Related Issue(s)
Closes #8267
Checklist
Deployment Notes