-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtorc: code cleanup #8269
vtorc: code cleanup #8269
Conversation
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
… legacy read/writes to instance_dao Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Initial commits: removing |
Next commit: removing all Pseudo-GTID related code. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Remove Agent-related code. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Removed graphite-related code. |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
cc @GuptaManan100 @deepthi @sougou for visibility |
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
The obvious irrelevant parts are gone. There's still potential for cleanup for:
but these are more nuanced and require a bit more delicate surgery. I'm confident and good to go with current cleanup for starters. |
I intend to follow up with more PR(s) that are more nuanced. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
I'll be stripping away irrelevant code from
vtorc
. Examples for code I'll remove:raft
consensusvtorc
gets hostnames fromtopo
, no need to resolve names)vtorc
gets information directly from Vitess, no need to probe instance for info)Related Issue(s)
No tracking issue at this time.
Checklist
Deployment Notes