Fix TableGC flaky test by reducing check interval #8270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
shlomi-noach
changed the title
|
|
|
I've manually restarted a dozen or so tabletmanager_tablegc` tests and they seem well. There was one failure that seemed unrelated and affected multiple steps of the test. |
Closed
|
🤞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7984
#7984 only happens on GitHub CI, never locally. This is the 2nd time I'm looking into it, with same conclusion: it's a timing/timeout issue. In this PR I make the parge check interval configurable, and set it to
5sas opposed to1min, expecting the test to now pass.Related Issue(s)
#7984
Checklist