[workflow] Call scanWorkflow concurrently
#8272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajm188
added
Type: Enhancement
`scanWorkflow` involves a remote call to a tablet to get the `copy_state` rows for the workflow stream associated with that tablet. Calling this concurrently gives us a noticeable speedup, especially on workflows involving many streams. Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_vtctld_concurrent_scanworkflow
branch
from
0f66a5c
to
b31abf9
Compare
doeg
approved these changes
Jun 15, 2021
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jun 15, 2021
…scanworkflow [workflow] Call `scanWorkflow` concurrently Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
…scanworkflow [workflow] Call `scanWorkflow` concurrently Signed-off-by: Andrew Mason <amason@slack-corp.com>
8 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
scanWorkflowinvolves a remote call to a tablet to get thecopy_staterows for the workflow stream associated with that tablet.Calling this concurrently gives us a noticeable speedup, especially on
workflows involving many streams.
Signed-off-by: Andrew Mason amason@slack-corp.com
Related Issue(s)
getCopyStatesmakes a remoteVReplicationExeccall in a loop, serially. we should make that happen concurrently. #8271Checklist
Deployment Notes