proto: enable pooling for vreplication #8273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicent Marti <vmg@strn.cat>
systay
reviewed
Jun 8, 2021
systay
reviewed
Jun 8, 2021
systay
approved these changes
Jun 8, 2021
|
when this optimizer attach to DML? It's a wonderful thing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the optimization that is fully described in this blog post. The blog post also includes a performance graph so this issue description is rather light. :)
I'm actively looking at more places where memory pooling makes sense, but for now VReplication is a clear winner and I think we can merge this right away.
Related Issue(s)
Checklist
Deployment Notes