Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: upgrade to Go 1.16 #8274

Merged
merged 7 commits into from
Jun 29, 2021
Merged

ci: upgrade to Go 1.16 #8274

merged 7 commits into from
Jun 29, 2021

Conversation

vmg
Copy link
Collaborator

@vmg vmg commented Jun 7, 2021

Description

Heyyyoo. 1.16 is stable enough to warrant an upgrade. No breakages are expected here.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@dkhenry
Copy link
Contributor

dkhenry commented Jun 7, 2021

This will require you to rebuild the bootstrap images as well. I don't think this specific upgrade will have any dependency conflicts, but we added in a bootstrap_version flag so we could safely upgrade the bootstrap image without impacting previous builds. You should update the flag in the main Makefile as part of this PR so that all images prior to this PR continue to use 1.15 and only new builds use 1.16

https://github.com/vitessio/vitess/blob/696e1f51d0d2ebdd80b442e1d904287a696a923f/Makefile#L247

dkhenry
dkhenry previously requested changes Jun 7, 2021
View reviewed changes
Copy link
Contributor

@dkhenry dkhenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bump bootstrap_version as well to ensure old versions continue to use 1.15

@vmg vmg force-pushed the go1.16 branch 2 times, most recently from 68ad219 to 4c8000a Compare June 8, 2021 13:35
@vmg
Copy link
Collaborator Author

vmg commented Jun 8, 2021

PR is currently blocked until I get access to Dockerhub to push the new images.

vmg added 7 commits June 29, 2021 12:04
@vmg
ci: upgrade to Go 1.16
e40989a 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@vmg
docker: update bootstrap version
26107d3 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@vmg
gomod: tidy
e48b53d 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@vmg
docker: remove keys.gnupg.net dependency
6c55d1d 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@vmg
rebuild CI
d3f3d4b 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@vmg
actions: update workflows
a8cb133 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@vmg
bootstrap: update chromedriver version
bbd490c 
Signed-off-by: Vicent Marti <vmg@strn.cat>
@vmg
Copy link
Collaborator Author

vmg commented Jun 29, 2021

@dkhenry I've bumped the version number and uploaded new Docker images. Can you approve?

@vmg
Copy link
Collaborator Author

vmg commented Jun 29, 2021

This PR is now green. Sorry for the delay, we had serious issues with DockerHub that have now been worked around. The Go 1.16 upgrade is ready to merge.

@vmg vmg merged commit f873339 into vitessio:main Jun 29, 2021
@vmg vmg deleted the go1.16 branch June 29, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@shlomi-noach shlomi-noach Awaiting requested review from shlomi-noach

@dkhenry dkhenry Awaiting requested review from dkhenry

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vmg @dkhenry @harshit-gangal