Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TableName to DiffReport struct. #8279

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Conversation

makinje16
Copy link
Contributor

Signed-off-by: Malcolm Akinje makinje@slack-corp.com

Description

This PR adds in TableName to the DiffReport struct. This is so when using a vtctl command with the json output, instead of getting output like

 {
"ProcessedRows": 0,
"MatchingRows": 0,
"MismatchedRows": 0,
"ExtraRowsSource": 0,
"ExtraRowsTarget": 0
}

We get:

 {
"ProcessedRows": 0,
"MatchingRows": 0,
"MismatchedRows": 0,
"ExtraRowsSource": 0,
"ExtraRowsTarget": 0,
"TableName": "t1"
}

This makes it easier to parse and also see what tables have diffs versus seeing what individual tables have diffs and not being able to see the overall information for the vdiff run for that table.

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
Signed-off-by: Malcolm Akinje <makinje@slack-corp.com>
@makinje16 makinje16 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Cluster management and removed Component: Cluster management labels Jun 7, 2021
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: VReplication Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants