Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Tracking Flaky Test: Ignore unrelated gtid progress events #8283

Merged
merged 1 commit into from
Jun 8, 2021

Conversation

rohit-nayak-ps
Copy link
Contributor

@rohit-nayak-ps rohit-nayak-ps commented Jun 8, 2021

Description

This PR is an attempt to fix the flakiness detected recently in TestSchemaVersioning such as

--- FAIL: TestSchemaVersioning (0.18s)
Error:     vstreamer_test.go:168: expectLog: got too many events: insert into vitess_version values(1, 10): evs
        [type:GTID timestamp:1623069305 gtid:"MySQL56/b1f2fc17-c78c-11eb-a879-000d3ae5ac36:1-323" current_time:1623069305115892459 type:FIELD timestamp:1623069305 field_event:{table_name:"vitess_version" fields:{name:"id1" type:INT32 table:"vitess_version" org_table:"vitess_version" database:"vttest" org_name:"id1" column_length:11 charset:63 flags:32768} fields:{name:"id2" type:INT32 table:"vitess_version" org_table:"vitess_version" database:"vttest" org_name:"id2" column_length:11 charset:63 flags:32768}} current_time:1623069305196910293 type:ROW timestamp:1623069305 row_event:{table_name:"vitess_version" row_changes:{after:{lengths:1 lengths:2 values:"110"}}} current_time:1623069305196926493 type:GTID timestamp:1623069305 gtid:"MySQL56/b1f2fc17-c78c-11eb-a879-000d3ae5ac36:1-324" current_time:1623069305196936493], want
        [type:FIELD field_event:{table_name:"vitess_version" fields:{name:"id1" type:INT32 table:"vitess_version" org_table:"vitess_version" database:"vttest" org_name:"id1" column_length:11 charset:63} fields:{name:"id2" type:INT32 table:"vitess_version" org_table:"vitess_version" database:"vttest" org_name:"id2" column_length:11 charset:63}} type:ROW row_event:{table_name:"vitess_version" row_changes:{after:{lengths:1 lengths:2 values:"110"}}} gtid], >> got length 4, wanted length 3

Local failures indicate this is happening due to an additional BEGIN/GTID/COMMIT group of events that happens at different times in the test causing event comparisons to fail at different points in that test. It is not clear what is causing it: it could be some _vt schema changes or some unrelated dmls from parallel or teardowns previous tests that are running concurrently.

This PR ignores such gtid progress events that can race with the events that the schema versioning test expects.

Signed-off-by: Rohit Nayak rohit@planetscale.com

…hat the schema versioning test expects

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@systay systay merged commit 8e4bada into vitessio:main Jun 8, 2021
@systay systay deleted the rn-tracker-flaky-test branch June 8, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants