Add /debug/env for vtgate #8292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
systay
added
Component: Query Serving
Type: Enhancement
deepthi
approved these changes
Jun 22, 2021
deepthi
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
|
Screenshot: |
aquarapid
added a commit
to planetscale/vitess
that referenced
this pull request
Jun 29, 2021
Signed-off-by: Jacques Grove <aquarapid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the vttablet /debug/env handler, borrow the code to make one for vtgate.
Initial use-case is to enable changing new healthcheck flags without a vtgate restart. Having the getter/setters for the various flags in
replicationlag.gois not idiomatic, but it minimizes changes. Open to suggestions.Not putting for this on the vtgate homepage (yet).