Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parser] use table_alias for ENGINE option in CREATE TABLE stmt #8307

Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 10, 2021

fixes: #8241

Signed-off-by: Alex Charis alex.charis@shopify.com

Description

The program attached to the linked issue now outputs:

&{false {foo } false 0xc000120480 <nil> [] true} <nil>
&{false {foo } false 0xc000120600 <nil> [] true} <nil>
&{false {foo } false 0xc000120780 <nil> [] true} <nil>

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Signed-off-by: Alex Charis <alex.charis@shopify.com>
@ghost ghost requested a review from systay June 10, 2021 20:36
@ghost ghost added Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Jun 10, 2021
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💕

Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look good. A test is needed for it to merge.

Signed-off-by: Alex Charis <alex.charis@shopify.com>
@ghost ghost requested a review from harshit-gangal June 14, 2021 14:55
@harshit-gangal harshit-gangal merged commit 2bb0232 into vitessio:main Jun 15, 2021
@ghost ghost deleted the create-table-non-reserved-keyword branch June 15, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL Parser fails on CREATE TABLE query with ENGINE option set to a non-reserved keyword.
3 participants