[vtctldserver] Update tests to prevent races during tmclient init #8320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Jun 12, 2021
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
[vtctldserver] Update tests to prevent races during tmclient init
8 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Mason amason@slack-corp.com
Description
Prior to this change, running the full
grpcvtctldservertest suite a few times would occasionally produce a panic, ultimately owing to:fatal error: concurrent map read and map write. The stack, which I didn't copy, and the RNG deities are not cooperating right now, points back totmclient.NewTabletManagerClientcoming from various tests here.So, I went through the tests and found any test that was using
t.Parallel()(good!) but not using thetestutil.NewVtctldServerWithTabletManagerClient()(less good!).Related Issue(s)
Checklist
Deployment Notes