[vtctldserver] Add additional backup info fields #8321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajm188
added
Type: Enhancement
doeg
approved these changes
Jun 12, 2021
| Name: bh.Name(), | ||
| Directory: bh.Directory(), | ||
| } | ||
|
|
||
| if parts := strings.Split(bi.Name, "."); len(parts) == 3 { |
There was a problem hiding this comment.
Non-blocking (scope-creepy) suggestion: colocating this backup name parse logic with the format call that happens in mysqlctl/backup.go could be useful for searchability (and any future refactors).
| topodata.TabletAlias tablet_alias = 5; | ||
| vttime.Time time = 6; | ||
|
|
||
| // The following fields are may or may not be currently set. Work is inflight |
There was a problem hiding this comment.
It might be useful to create + link an issue for this. Up to you!
…tBackupsRequest Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
…, add limiting Signed-off-by: Andrew Mason <amason@slack-corp.com>
We're not including the Detailed fields here yet, because they are unused in the server implementation (for now). Signed-off-by: Andrew Mason <amason@slack-corp.com>
Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
force-pushed
the
am_additional_backup_info
branch
from
b280a4d
to
411950f
Compare
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jun 15, 2021
…info [vtctldserver] Add additional backup info fields Signed-off-by: Andrew Mason <amason@slack-corp.com>
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
…info [vtctldserver] Add additional backup info fields Signed-off-by: Andrew Mason <amason@slack-corp.com>
8 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following additional fields to the
BackupInfoproto message:Keyspace=> set by VtctldServerShard=> set by VtctldServerTime=> the time the backup started, parsed out of the backuphandle name, set byBackupHandleToProtoTabletAlias=> the alias of the tablet that took the backup, parsed out of the backuphandle name, set byBackupHandleToProtoEngine=> the name of the backupstorage engine that produced the backup, currently unset, to be added in a future PRStatus=> the status of the backup, to be set by a combination of the backupengine implementation and the backupstorage.BackupHandle implementation; currently unset, to be added in a future PR.We also add limiting fields to the GetBackupsRequest, to reduce the number of backup infos that have to be marshaled and sent over network; this is especially useful in the case where the caller is interested only in the most recent backup. In a future change we can revisit adding time-based filtering (i.e. "give me all backups before $x and after $y"), but I didn't want to tackle that now.
Finally, I updated the CLI to expose the limit field, and also to change the posargs from
$keyspace $shardas two arguments to the more standard${keyspace}/${shard}single argument.Examples:
Related Issue(s)
#7352
Checklist
Deployment Notes