VReplication (and by product, Online DDL): support GENERATED column as part of PRIMARY KEY #8335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s part of PRIMARY KEY Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
|
This is nice! Another edge case in vreplication handled :-) The online ddl test tests both the copy and replication phase, right? So we don't need to add explicit tests for this case as part of the vcopier/vplayer testsuite, right? |
Correct! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Worked to add/fix Online DDL/VReplication suite test
generated-columns57-unique, an dended up fixing something more generic to VReplication:PRIMARY KEY.GENERATEDcolumnsPRIMARY KEYcolumnsThe combination of (2+3) contradicts (1).
With this PR, VReplication does not require (3) for
GENERATEDcolumns.Related Issue(s)
Checklist