[vtctldproxy] Add more annotations to vtctld Dial calls

[ajm188]

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

Exactly what it says in the title. This gives us info about the cluster that we're dialing, as well as the underlying vtctld hostname we're using, including when the dial is a no-op.

Related Issue(s)

Checklist

• Tests were added or are not required -- n/a
• Documentation was added or is not required -- n/a

Deployment Notes

[ajm188]

maybe rebasing will help? nope, i'm branched off latest main

[ajm188]

It's this test, consistently:

=== RUN   TestSchemaChange/update-pk
    onlineddl_vrepl_suite_test.go:290: 
        	Error Trace:	onlineddl_vrepl_suite_test.go:290
        	            				onlineddl_vrepl_suite_test.go:149
        	Error:      	Not equal: 
        	            	expected: "1\t5\tdark grey\n2\t7\tyellow\n3\t11\tgreen\n3\t11\tred\n4\t13\tgreen\n5\t17\torange\n6\t11\tgreen\n6\t11\tred\n7\t13\tgreen\n8\t17\torange\n9\t11\tgreen\n9\t11\tred\n10\t13\tgreen\n11\t17\torange\n12\t11\tgreen\n12\t11\tred\n13\t13\tgreen\n14\t17\torange\n15\t11\tgreen\n15\t11\tred\n16\t13\tgreen\n17\t17\torange\n18\t11\tgreen\n18\t11\tred\n19\t13\tgreen\n20\t17\torange\n21\t11\tgreen\n21\t11\tred\n22\t13\tgreen\n23\t17\torange\n24\t11\tgreen\n24\t11\tred\n25\t13\tgreen\n26\t17\torange\n27\t11\tgreen\n27\t11\tred\n28\t13\tgreen\n29\t17\torange\n30\t11\tgreen\n30\t11\tred\n31\t13\tgreen\n32\t17\torange\n"
        	            	actual  : "1\t5\tdark grey\n2\t7\tyellow\n3\t11\tgreen\n3\t11\tred\n4\t13\tgreen\n5\t17\torange\n6\t11\tgreen\n6\t11\tred\n7\t13\tgreen\n8\t17\torange\n9\t11\tgreen\n9\t11\tred\n10\t13\tgreen\n11\t17\torange\n12\t11\tgreen\n12\t11\tred\n13\t13\tgreen\n14\t17\torange\n15\t11\tgreen\n15\t11\tred\n16\t13\tgreen\n17\t17\torange\n18\t11\tgreen\n18\t11\tred\n19\t13\tgreen\n20\t17\tblue\n21\t11\tgreen\n21\t11\tred\n22\t13\tgreen\n23\t17\tblue\n24\t11\tgreen\n24\t11\tred\n25\t13\tgreen\n26\t17\tblue\n27\t11\tgreen\n27\t11\tred\n28\t13\tgreen\n29\t17\tblue\n30\t11\tgreen\n30\t11\tred\n31\t13\tgreen\n32\t17\tblue\n"
        	            	
        	            	Diff:
        	            	--- Expected
        	            	+++ Actual
        	            	@@ -25,3 +25,3 @@
        	            	 19	13	green
        	            	-20	17	orange
        	            	+20	17	blue
        	            	 21	11	green
        	            	@@ -29,3 +29,3 @@
        	            	 22	13	green
        	            	-23	17	orange
        	            	+23	17	blue
        	            	 24	11	green
        	            	@@ -33,3 +33,3 @@
        	            	 25	13	green
        	            	-26	17	orange
        	            	+26	17	blue
        	            	 27	11	green
        	            	@@ -37,3 +37,3 @@
        	            	 28	13	green
        	            	-29	17	orange
        	            	+29	17	blue
        	            	 30	11	green
        	            	@@ -41,3 +41,3 @@
        	            	 31	13	green
        	            	-32	17	orange
        	            	+32	17	blue
        	            	 
        	Test:       	TestSchemaChange/update-pk
        	Messages:   	results mismatch: (select * from onlineddl_test_before ) and (select * from onlineddl_test_after )