Make timestamp authoritative for master information #8381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s old information Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
Signed-off-by: GuptaManan100 <manan@planetscale.com>
GuptaManan100
added
Component: Cluster management
Type: Bug
Type: Testing
and removed
Type: Bug
labels
GuptaManan100
requested review from
ajm188,
deepthi,
doeg,
rohit-nayak-ps and
shlomi-noach
as code owners
Signed-off-by: GuptaManan100 <manan@planetscale.com>
GuptaManan100
force-pushed
the
sync-shard
branch
from
6529811
to
5fd91f0
Compare
deepthi
approved these changes
Jun 24, 2021
Signed-off-by: GuptaManan100 <manan@planetscale.com>
harshit-gangal
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes it explicit in all the places and
shard_syncthat the timestamp for the master term is the authoritative source of information for who is the master. We sync the information between the tablet record and shard record based on the timestamp.Related Issue(s)
Checklist