Resolve go.mod issue with direct dependency on planetscale/tengo #8383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
vmg
approved these changes
Jun 24, 2021
Not sure how to do that while the PR is unmerged? Tried: $ go get vitess.io/vitess/go/cmd/vtctlclient@c2cfb0ebfd424a308c0445b097c9d24bdfa20ab4
go get: vitess.io/vitess/go/cmd/vtctlclient@c2cfb0ebfd424a308c0445b097c9d24bdfa20ab4: invalid version: unknown revision c2cfb0ebfd424a308c0445b097c9d24bdfa20ab4 |
|
hmmm the reason this won't work is that the PR comes from |
|
You know something, I don't even know what |
|
@shlomi-noach: it's a n HTML Here are the full docs FWIW: https://golang.org/cmd/go/#hdr-Remote_import_paths |
|
This actually worked 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/planetscale/tengo is a fork of https://github.com/skeema/tengo, where we add Vitess-specific code that is not likely to fit
skeema/tengo.Until today, we did a
replace github.com/skeema/tengo => github.com/planetscale/tengo v0.9.6-ps.v3ingo.mod. This worked well for complete Vitess builds (make buildetc).However, we found out that in partial builds, such as in
go get vitess.io/vitess/go/cmd/vtctlclient,godoes not resolve the redirect correctly.With this PR, we directly import
planetscale/skeema. We also renamedplanetscale/tengo's module name itself in planetscale/tengo#8 and tagged that asv0.9.6-ps.v4.Related Issue(s)
Issue by community in slack.
Checklist