[grpcvtctldserver] Fix backup detail limit math #8402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We always want to base off the total number of backups, not the total number after applying the overall limit. Signed-off-by: Andrew Mason <amason@slack-corp.com>
doeg
approved these changes
Jun 29, 2021
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 6, 2021
…il_fix [grpcvtctldserver] Fix backup detail limit math
7 tasks
ajm188
added a commit
to tinyspeck/vitess
that referenced
this pull request
Jul 23, 2021
…il_fix [grpcvtctldserver] Fix backup detail limit math
8 tasks
33 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We always want to base off the total number of backups, not the total
number after applying the overall limit.
Signed-off-by: Andrew Mason amason@slack-corp.com
Description
tl;dr I'm bad at math. Consider this:
limit = 10detailedLimit = 5Then,
totalBackups = req.Limit= 10backupsToSkip = len(bhs) - totalBackups= 25 - 10 = 15backupsToSkipDetails = totalBackups - detailedLimit= 10 - 5 = 5this means we would skip getting details for only the first 5 backups, and show details for the remaining
25 - 5 = 20backups (then, after applying the overall limit, we would show details for all 10 backups).Related Issue(s)
Checklist
Deployment Notes