Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for reparent endtoend test flakiness #8642

Merged
merged 1 commit into from Aug 20, 2021
Merged

Fixes for reparent endtoend test flakiness #8642

merged 1 commit into from Aug 20, 2021

Conversation

eeSeeGee
Copy link
Contributor

@eeSeeGee eeSeeGee commented Aug 18, 2021 •
edited

Extended timeout for replication restoration, which sometimes seems to
take a while in CI.

Additionally made test insert rows truly unique, which I'm not sure
fixed anything but makes it much easier to check the state of
replication.

Signed-off-by: Aaron Young young@squareup.com

Description

Related Issue(s)

Checklist

  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@eeSeeGee
Fixes for reparent endtoend test flakiness
2a53305 
Extended timeout for replication restoration, which sometimes seems to
take a while in CI.

Additionally made test insert rows truly unique, which I'm not sure
fixed anything but makes it much easier to check the state of
replication.

Signed-off-by: Aaron Young <young@squareup.com>
@deepthi
Copy link
Member

deepthi commented Aug 18, 2021

Did this help at all? Which tests were you trying to stabilize?

@eeSeeGee
Copy link
Contributor Author

The specific test we were having trouble with was TestReparentWithDownReplica, which ran ok locally but would usually fail in CI. We have some pretty pokey CI machines so that seemed pretty suspicious. With this change it seems to be stable.

@deepthi deepthi requested a review from ajm188 August 19, 2021 01:16
@deepthi
Copy link
Member

deepthi commented Aug 19, 2021

The specific test we were having trouble with was TestReparentWithDownReplica, which ran ok locally but would usually fail in CI. We have some pretty pokey CI machines so that seemed pretty suspicious. With this change it seems to be stable.

Ok, then it is worth the changes.. Do you have the necessary permissions to re-run the failing tests? (Which all seem like flaky ones).

@eeSeeGee
Copy link
Contributor Author

I don't seem to have permissions to re-run tests

@deepthi
Copy link
Member

deepthi commented Aug 19, 2021

I don't seem to have permissions to re-run tests

I invited you to the contributor team. That will give you the necessary permissions.
I have re-run all the failing tests for now. Let's hope they pass on this iteration.

deepthi
deepthi approved these changes Aug 19, 2021
View reviewed changes
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eeSeeGee
Copy link
Contributor Author

Looks like we're good! I also can't merge apparently :)

@deepthi deepthi merged commit 56a2288 into vitessio:main Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi deepthi approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188

Assignees
No one assigned
Labels
Component: Build/CI Type: CI/Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eeSeeGee @deepthi @frouioui