Use fmt.Fprintf instead of fmt.Sprintf
#8922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdakkota
requested review from
ajm188,
doeg,
harshit-gangal,
rohit-nayak-ps,
shlomi-noach and
systay
as code owners
This commit replaces fmt.Sprintf calls with fmt.Fprintf and friends where it is possible. The w.Write([]byte(fmt.Sprintf(...))) pattern is quite inefficient, it allocates 3x more than fmt.Fprintf variant. Signed-off-by: tdakkota <tanc13@yandex.ru>
tdakkota
force-pushed
the
fix/prefer-fprints
branch
from
fa26980
to
9b3b186
Compare
systay
added
Component: Query Serving
Component: VTAdmin
ajm188
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces
fmt.Sprintfcalls withfmt.Fprintfand friendswhere it is possible.
The
w.Write([]byte(fmt.Sprintf(...)))pattern is quite inefficient, it allocates3x more than
fmt.Fprintf.I see that this PR changes only some debug and observability-related code. Anyway, I hope it will be helpful.