Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix boolean parameter order in DropSources call for v2 flows #9175

Merged
merged 1 commit into from Nov 10, 2021

Conversation

ajm188
Copy link
Contributor

@ajm188 ajm188 commented Nov 9, 2021

Signed-off-by: Andrew Mason amason@slack-corp.com

Description

This corrects the boolean param passing order to DropSources made by v2 vreplication flows

Related Issue(s)

Fixes #9174

Checklist

  • Should this PR be backported? yes
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Copy link
Member

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ajm188 ajm188 merged commit 99be710 into vitessio:main Nov 10, 2021
@ajm188 ajm188 deleted the v2-dropsources-keepdata branch November 10, 2021 00:26
ajm188 added a commit to ajm188/vitess that referenced this pull request Nov 10, 2021
Fix boolean parameter order in DropSources call for v2 flows
ajm188 added a commit to ajm188/vitess that referenced this pull request Nov 10, 2021
Fix boolean parameter order in DropSources call for v2 flows

Signed-off-by: Andrew Mason <amason@slack-corp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

-keep_data is ignored in v2 vreplication workflows
2 participants