Backport-12.0: Take MySQL Column Type Into Account in VStreamer #9355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required when we need to match MySQL behavior for data that requires column type information as well. For example, the binlog event metadata makes no distinction between events for a BINARY(4) column and events for a CHAR(4) column with a binary collation like utf8mb4_bin. So we need to know the underlying MySQL column type in order to handle them disctinctly -- MySQL pads (fixed length) binary columns on the right side with null bytes, but it does NOT do that for (fixed lengthed) CHARo columns, regardless of the collation. Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
requested review from
harshit-gangal,
shlomi-noach and
systay
as code owners
mattlord
added
Type: Bug
Component: VReplication
Backport
mattlord
requested review from
deepthi and
rohit-nayak-ps
and removed request for
systay,
shlomi-noach and
harshit-gangal
mattlord
force-pushed
the
Backport_9331_12.0
branch
4 times, most recently
from
eac76be
to
137203c
Compare
And use ToLower when looking for BINARY types to be safe. Signed-off-by: Matt Lord <mattalord@gmail.com>
mattlord
force-pushed
the
Backport_9331_12.0
branch
from
137203c
to
25ff004
Compare
deepthi
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of #9331. Please see details there.
Related Issue(s)
Checklist