-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Online DDL declarative migrations now use schemadiff, removing tengo #9772
Online DDL declarative migrations now use schemadiff, removing tengo #9772
Conversation
…ency Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is, again, great just from the sheer amount of dependencies it removes. I don't have a good enough understanding of the subsystem to approve the changes so I'm basically giving my thumbs up to the go.mod
diff. :)
/assign @vitessio/query-serving |
call for review 🙏 |
Tracking issue: #10203 |
Description
Now that #9719 is merged, we switch
-declarative
migrations from usingtengo
into usingschemadiff
. In this change:executor.go
now usesschemadiff
's declarative diff based onSHOW CREATE TABLE
output from original and ghost tablessqlx
tengo
librarygo.mod
)Tests-wise, the PR remains covered by
onlineddl_declarative
.Related Issue(s)
Checklist