[topo/helpers] Make CopyShardReplications idempotent #9849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Mason <andrew@planetscale.com>
vmg
requested changes
Mar 10, 2022
go/vt/topo/helpers/copy.go
Outdated
| @@ -168,8 +170,27 @@ func CopyShardReplications(ctx context.Context, fromTS, toTS *topo.Server) { | |||
| continue | |||
| } | |||
|
|
|||
| sriNodes := sets.NewString() | |||
There was a problem hiding this comment.
This k8s.io/apimachinery dependency seems a bit out of place. We don't usually depend on these helpers in Vitess. Since all you need is a simple String Set, you can make one with a map[string]struct{} that would be just as readable/ergonomic.
Signed-off-by: Andrew Mason <andrew@planetscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates
helpers.CopyShardReplicationsto build a set of tablet aliases in the fromTS topo so that repeated copies are idempotent.Related Issue(s)
Fixes #9844
Checklist
Deployment Notes