Add parsing support for JSON Utility Functions #9850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
K-Kumar-01
requested review from
harshit-gangal,
systay,
shlomi-noach and
GuptaManan100
as code owners
K-Kumar-01
added
Component: Query Serving
release notes
Type: Enhancement
GuptaManan100
requested changes
Mar 17, 2022
…tility struct Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
K-Kumar-01
force-pushed
the
json-utility-function-support
branch
from
ef0a39a
to
abf9a53
Compare
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
frouioui
reviewed
Mar 22, 2022
go/vt/sqlparser/ast.go
Outdated
Comment on lines
2226
to
2231
| // JSONUtilityExpr represents set of JSON utility functions | ||
| // More information on https://dev.mysql.com/doc/refman/8.0/en/json-utility-functions.html | ||
| JSONUtilityExpr struct { | ||
| Name ColIdent | ||
| StringArg Expr | ||
| } |
There was a problem hiding this comment.
I think @GuptaManan100 is right. Even though the three different utility functions (JSON_PRETTY, JSON_STORAGE_SIZE, JSON_STORAGE_FREE) have the same signature, it would be more readable/debuggable to have them as separate AST nodes or have an identifiable name (such as an enum).
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
Create separate structs and format function for each struct Update parser to use corresponding structs Remove previously used JSONUtilityExpr struct Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
approved these changes
Mar 23, 2022
28 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the parsing support for JSON Utility functions. More information here
Changes made
Related Issue(s)
#8604
#4099
Related PR: #9352
Checklist
Deployment Notes