Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parsing support for Json schema validation functions #9971

Merged
merged 8 commits into from Apr 7, 2022
Merged

Add parsing support for Json schema validation functions #9971

merged 8 commits into from Apr 7, 2022

Conversation

K-Kumar-01
Copy link
Contributor

Description

Adds the parsing support for JSON schema validation functions.
More information here.

Changes

  • Parser file grammar support.
  • Valid and Invalid test cases.

Related Issue(s)

#8604
#4099

Checklist

  • Should this PR be backported?
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@K-Kumar-01
feat: add parsing support for JSON Schema Validation Functions
95b80f9 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
ci: fix number of expected conflicts
72a9b60 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01 K-Kumar-01 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes labels Mar 23, 2022
K-Kumar-01 and others added 6 commits April 5, 2022 23:03
@K-Kumar-01
Merge branch 'main' into json-schema-validation-functions
8a9dcea 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
ci: update number of expected shift/reduce conflicts
6aba726 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
tests: use ignoreNormalizer in the failing tests
a32e6d0 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@GuptaManan100
test: add planner tests for search and validation functions
6a3a3d4 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: add end to end test for json search and validation functions
bcc6716 
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100
test: add tests for shorthands as well
1838a80 
Signed-off-by: Manan Gupta <manan@planetscale.com>
GuptaManan100
GuptaManan100 approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Work 🎉

@GuptaManan100 GuptaManan100 mentioned this pull request Apr 7, 2022
Merged
3 tasks
frouioui
frouioui approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Awesome 🎊

@GuptaManan100 GuptaManan100 merged commit cc62452 into vitessio:main Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@K-Kumar-01 @frouioui @GuptaManan100