Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parsing support for JSON Search Functions #9990

Merged
merged 13 commits into from Apr 5, 2022
Merged

Add parsing support for JSON Search Functions #9990

merged 13 commits into from Apr 5, 2022

Conversation

K-Kumar-01
Copy link
Contributor

@K-Kumar-01 K-Kumar-01 commented Mar 27, 2022 •
edited

Description

Add the parsing support for JSON search functions. More details here

Related Issue(s)

#8604
#4099

Checklist

  • Should this PR be backported?No
  • Tests were added or are not required
  • Documentation was added or is not required

Deployment Notes

@K-Kumar-01
feat: add parsing support for search functions
1a333e2 
Add the structs, parsing, formatting and tests
JSON_SEARCH and value MEMBER OF not supported yet

Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
feat: add parsing support for JSON_SEARCH()
4663d55 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01 K-Kumar-01 added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving release notes labels Mar 27, 2022
@K-Kumar-01
feat: change JSONParamPath type from struct to Expr
bca03f6 
update parser
update formatting

Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
tests: add test for updated parser
1f24d7d 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
Merge branch 'main' into json-search-functions
dd35973 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
tests: update invalid test case
8c5a447 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
refactor: remove commented code
8742df7 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01 K-Kumar-01 marked this pull request as ready for review March 29, 2022 15:20
@K-Kumar-01
ci: update number of expected shift/reduce conflicts
4e4c2ae 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
GuptaManan100
GuptaManan100 reviewed Mar 31, 2022
View reviewed changes
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add tests for the shorthands -> and ->>

go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
go/vt/sqlparser/sql.y Outdated Show resolved Hide resolved
go/vt/sqlparser/keywords.go Outdated Show resolved Hide resolved
@K-Kumar-01
refactor: reorder words in ascending order
dfc27d8 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
ci: fix number of expected shift/reduce conflicts
bb90f8e 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
feat: add parsing support for MEMBER OF
ed8da40 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
Merge branch 'main' into json-search-functions
447cbc8 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@K-Kumar-01
refactor: use text_literal_or_arg in place of text_literal
2c95f01 
Signed-off-by: Kushal Kumar <kushalkumargupta4@gmail.com>
@GuptaManan100 GuptaManan100 merged commit d7cd8cc into vitessio:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekperkins derekperkins derekperkins left review comments

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal is a code owner

@systay systay Awaiting requested review from systay systay is a code owner

Assignees
No one assigned
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@K-Kumar-01 @derekperkins @GuptaManan100