Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: OnlineDDL cut-over backoff and force-cut-over #1641

Merged
merged 9 commits into from Dec 13, 2023

Conversation

shlomi-noach
Copy link
Contributor

Documenting the changes in vitessio/vitess#14546:

  • ALTER VITESS_MIGRATION ... FORCE_CUTOVER ...
  • --force-cut-over-after strategy flag
  • Cutover backoff
  • How forced cut-over works

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for vitess ready!

Name Link
🔨 Latest commit 547f274
🔍 Latest deploy log https://app.netlify.com/sites/vitess/deploys/65795b65d10a990008ea598d
😎 Deploy Preview https://deploy-preview-1641--vitess.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shlomi-noach shlomi-noach changed the title Docs onlineddl force cutover Docs: OnlineDDL cut-over backoff and force-cut-over Nov 20, 2023
Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you generate the vtctldclient docs for the new command as well?

@shlomi-noach
Copy link
Contributor Author

can you generate the vtctldclient docs for the new command as well?

Completely forgot how to do that 😬

@ajm188
Copy link
Contributor

ajm188 commented Nov 30, 2023

in your particular case (I think):

COBRA_DOC_VERSION_PAIRS=onlineddl-cutover-backoff:19.0 make vtctldclient-docs

edit: also you'll need to point it at your local vitess checkout https://github.com/vitessio/website/blob/prod/Makefile#L104

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

OK did that. That updated plenty CLI flags, but nothing related to the new command.

I feel like we've been in this situation before. I did run make build on my local path. I did point to the correct path:

COBRA_DOC_VERSION_PAIRS=onlineddl-cutover-backoff:19.0 VITESS_DIR=/Users/my-redacted-path make vttablet-docs

@ajm188
Copy link
Contributor

ajm188 commented Dec 4, 2023

OK did that. That updated plenty CLI flags, but nothing related to the new command.

I feel like we've been in this situation before. I did run make build on my local path. I did point to the correct path:

COBRA_DOC_VERSION_PAIRS=onlineddl-cutover-backoff:19.0 VITESS_DIR=/Users/my-redacted-path make vttablet-docs

you need to make vtctldclient-docs as that's where the command is: https://github.com/vitessio/vitess/pull/14546/files#diff-13c32ab29d8892d009025725f22f4c9bdf7433141be13cd0ef8fe0615ccefb36

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

you need to make vtctldclient-docs

Absolutely right! My mistake. Alas: did that, now over 450 new files changes -- none of which depicts the new command.

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
@shlomi-noach
Copy link
Contributor Author

@ajm188 having merged vitessio/vitess#14546, I tried again using COBRA_DOC_VERSION_PAIRS=main:19.0 and that worked. It looks to me like a non-main branch name just doesn't work?

@shlomi-noach
Copy link
Contributor Author

shlomi-noach commented Dec 13, 2023

The newly added file is content/en/docs/19.0/reference/programs/vtctldclient/vtctldclient_OnlineDDL/vtctldclient_OnlineDDL_force-cutover.md

I still have some extra ~465 files changed, but I guess that's fine as it's just the commit SHA?

Looking for your final approval before merging.

@shlomi-noach
Copy link
Contributor Author

Not sure why versions 16.0, 17.0, 18.0 were at all affected here. Again, I think the script just doesn't work correctly with a non-main branch name. Please advise.

@ajm188
Copy link
Contributor

ajm188 commented Dec 13, 2023

two things:

  1. the script definitely works with non-main branches last i used it (before i went on leave). you do need to make sure the branches (including those for the other versions you're generating) are up-to-date locally (git fetch --all should be enough)

  2. i think the extra noise is because the bot seems to have not been auto-generating docs, which i had working before i left. i am looking into why that is currently

Copy link
Contributor

@ajm188 ajm188 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that said, this is fine to merge!

@shlomi-noach
Copy link
Contributor Author

@ajm188 Thank you for the inspection and clarification!

@shlomi-noach shlomi-noach merged commit c0a5c49 into prod Dec 13, 2023
5 checks passed
@shlomi-noach shlomi-noach deleted the docs-onlineddl-force-cutover branch December 13, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants