fix: don't bind global classes

vitest-dev · May 20, 2022 · 2556f1b · 2556f1b
1 parent fa066cb
commit 2556f1b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/vitest/src/integrations/env/utils.ts b/packages/vitest/src/integrations/env/utils.ts
@@ -26,6 +26,10 @@ export function getWindowKeys(global: any, win: any) {
   return keys
 }
 
+function isClassLikeName(name: string) {
+  return name[0] === name[0].toUpperCase()
+}
+
 interface PopulateOptions {
   bindFunctions?: boolean
 }
@@ -40,7 +44,7 @@ export function populateGlobal(global: any, win: any, options: PopulateOptions =
 
   const overrideObject = new Map<string | symbol, any>()
   for (const key of keys) {
-    const bindedFunction = bindFunctions && typeof win[key] === 'function' && win[key].bind(win)
+    const bindedFunction = bindFunctions && typeof win[key] === 'function' && !isClassLikeName(key) && win[key].bind(win)
     Object.defineProperty(global, key, {
       get() {
         if (overrideObject.has(key))

diff --git a/test/core/test/dom.test.ts b/test/core/test/dom.test.ts
@@ -126,3 +126,9 @@ it('globals are the same', () => {
   expect(window.globalThis.Blob).toBe(globalThis.Blob)
   expect(Blob).toBe(globalThis.Blob)
 })
+
+it('can extend global class', () => {
+  class SuperBlob extends Blob {}
+
+  expect(SuperBlob).toBeDefined()
+})