chore: add a note about magic number

vitest-dev · Jan 29, 2022 · 698b67e · 698b67e
1 parent f9a4c09
commit 698b67e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/packages/vite-node/src/client.ts b/packages/vite-node/src/client.ts
@@ -91,6 +91,10 @@ export class ViteNodeRunner {
       },
     }
 
+    // Be carefull when changing this
+    // changing context will change amount of code added on line :114 (vm.runInThisContext)
+    // this messes up sourcemaps for coverage
+    // adjust `offset` variable in packages/vitest/src/integrations/coverage.ts#L100 if you do change this
     const context = this.prepareContext({
       // esm transformed by Vite
       __vite_ssr_import__: request,

diff --git a/packages/vitest/src/integrations/coverage.ts b/packages/vitest/src/integrations/coverage.ts
@@ -94,8 +94,8 @@ export async function reportCoverage(ctx: Vitest) {
       }
     }))
 
-  // This is a magic number it corresponds to the amount of code
-  // that we add in packages/vite-node/src/client.ts:110 (vm.runInThisContext)
+  // This is a magic number. It corresponds to the amount of code
+  // that we add in packages/vite-node/src/client.ts:114 (vm.runInThisContext)
   // TODO: Include our transformations in soucemaps
   const offset = 190